SOAR-0015: Error Handler Protocols for Client and Server #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @czechboy0, I've created the proposal document as suggested. Would appreciate your review when you have a chance! |
Contributor
|
Hi @winnisx7, thank you for your interest in contributing to Swift OpenAPI Generator. For now, we prefer human-written code and proposals, and your document appears to be written by an LLM. If you just used an LLM to format on your hand-written proposal, please just provide your original proposal, without running it through an LLM. That'll help protect other contributors' time by not having to read the usual extra fluff that LLMs add. I appreciate that every project is figuring out their own rules about LLM usage, and I do want to help you get your contribution reviewed and merged, let's just keep it between us humans :) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the proposal document for SOAR-0015, which introduces
ClientErrorHandlerandServerErrorHandlerprotocols for centralized error observation.Related Links
Motivation
Currently, swift-openapi-runtime provides limited options for centralized error handling. Developers must handle errors individually at each API call site, leading to code duplication. The existing
ClientMiddlewareoperates at the HTTP level and cannot intercept errors that occur during response decoding or other runtime operations.This proposal introduces protocol-based error handlers that are invoked after errors have been wrapped in
ClientErrororServerError, enabling centralized logging, monitoring, and analytics.What's in this PR
Sources/_OpenAPIGeneratorCore/Documentation.docc/Proposals/SOAR-0015.mdChecklist